-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add shouldUseVirtualFocus to AriaListBoxOptions interface (#1635) #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful! 🎉 |
label?: ReactNode, | ||
|
||
/** | ||
* Whether the collection items should use virtual focus instead of being focused directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick just so the description is more specific to the hook:
* Whether the collection items should use virtual focus instead of being focused directly. | |
* Whether the listbox options should use virtual focus instead of being focused directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, that makes sense.
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Build successful! 🎉 |
Closes #1635
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: