Skip to content

Conversation

reidbarber
Copy link
Member

Closes #1635

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Pass shouldUseVirtualFocus into useListBox
  2. Verify that there is no typescript warning (i.e. "Object literal may only specify known properties, and 'shouldUseVirtualFocus' does not exist in type 'AriaListBoxOptions'")

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

label?: ReactNode,

/**
* Whether the collection items should use virtual focus instead of being focused directly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick just so the description is more specific to the hook:

Suggested change
* Whether the collection items should use virtual focus instead of being focused directly.
* Whether the listbox options should use virtual focus instead of being focused directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that makes sense.

@adobe-bot
Copy link

Build successful! 🎉

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adobe-bot
Copy link

Build successful! 🎉

@reidbarber reidbarber merged commit 694f758 into main Jun 25, 2021
@reidbarber reidbarber deleted the Issue-1635 branch June 25, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shouldUseVirtualFocus is missing from AriaListBoxOptions
4 participants