Skip to content

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Feb 21, 2020

Fix the CSS, new postcss-calc plugin introduced a bug.
I believe this to be the issue postcss/postcss-calc#91
I'm hard locking us to the previous version until this matter is resolved

we have a range dep on it, got bumped when parcel css-nano was bumped, from yarn why postcss-calc

- Hoisted from "_project_#@spectrum-css#component-builder#postcss-calc"
- Hoisted from "_project_#postcss-calc"
- Hoisted from "_project_#parcel#@parcel#config-default#@parcel#optimizer-cssnano#cssnano#cssnano-preset-default#postcss-calc"

was easiest to put all of them on the same safe version using resolutions

These imports should be on the same line

Closes

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exist for this component).
  • Looked at the Accessibility Standard and/or talked to @mijordan about Accessibility for this feature.

📝 Test Instructions:

🧢 Your Team:

@adobe-bot
Copy link

Build successful! 🎉

I believe this to be the issue postcss/postcss-calc#91
I'm hard locking us to the previous version until this matter is resolved
@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger changed the title Radio docs minor cleanup Radio docs minor cleanup and fix CSS Feb 22, 2020
@dannify dannify merged commit c8b6e56 into master Feb 22, 2020
@dannify dannify deleted the combine-radio-imports branch February 22, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants