Skip to content

Update W3C APG links #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2022
Merged

Update W3C APG links #3204

merged 2 commits into from
Jun 8, 2022

Conversation

reidbarber
Copy link
Member

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@reidbarber reidbarber added the small review Easy to review PR label Jun 8, 2022
@adobe-bot
Copy link

Build successful! 🎉

ktabors
ktabors previously approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the updated links look good.

snowystinger
snowystinger previously approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good
Should we also use this time to change our wording from 'spec' to 'pattern' on the link card?
Screen Shot 2022-06-08 at 1 59 28 PM
"View ARIA pattern" because the second header of those pages is "About This Pattern"

@reidbarber reidbarber dismissed stale reviews from snowystinger and ktabors via a279e40 June 8, 2022 21:03
@reidbarber
Copy link
Member Author

Should we also use this time to change our wording from 'spec' to 'pattern' on the link card?

Sounds good to me, just updated

@adobe-bot
Copy link

Build successful! 🎉

@reidbarber reidbarber merged commit 18cb5bf into main Jun 8, 2022
@reidbarber reidbarber deleted the update-W3C-links branch June 8, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
small review Easy to review PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbarber @adobe-bot @ktabors @snowystinger