Make MenuTrigger render menus in a Tray on mobile #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 30, 2020
| isOpen | ||
| }); | ||
|
|
||
| let isMobile = useMediaQuery('(max-width: 700px)'); |
There was a problem hiding this comment.
should we hook up anything to screen resizing? probably not since it'd be unlikely that someone would change the screen size while a menu is open, and i think it closes when you try something like that?
There was a problem hiding this comment.
useMediaQuery does listen for matchMedia events, so that should already happen. 😄
| autoFocus: true, | ||
| wrapAround: true | ||
| wrapAround: true, | ||
| UNSAFE_style: { |
There was a problem hiding this comment.
Tray doesn't take care of this already?
There was a problem hiding this comment.
not at the moment. do you think it's safe to do that? wasn't sure if trays could have more than one child or something
|
Build successful! 🎉 |
dannify
approved these changes
Mar 31, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already implemented in Picker, but not MenuTrigger.