Skip to content

Fixing ListView drag preview badge #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fixing ListView drag preview badge #3389

merged 1 commit into from
Aug 8, 2022

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Aug 8, 2022

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Try dragging multiple ListView rows in the ListView drag stories. The badge shouldn't stretch to fill remaining space in the grid

🧢 Your Project:

RSP

@LFDanLu LFDanLu added the small review Easy to review PR label Aug 8, 2022
@adobe-bot
Copy link

Build successful! 🎉

@devongovett devongovett merged commit a57d9f4 into main Aug 8, 2022
@devongovett devongovett deleted the fix_drag_preview_badge branch August 8, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

small review Easy to review PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LFDanLu @adobe-bot @devongovett @snowystinger @reidbarber