Do not uppercase table headers #3530
Conversation
|
Build successful! 🎉 |
|
Looking at https://spectrum.adobe.com/page/table/, I think the font size looks too big, and the color looks too dim. |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| @@ -16,19 +16,20 @@ governing permissions and limitations under the License. | |||
| } | |||
|
|
|||
| .spectrum-Table-headCell { | |||
| color: var(--spectrum-table-header-text-color); | |||
| color: var(--spectrum-alias-text-color); | |||
There was a problem hiding this comment.
The text color in the XD file is #000000/rgb(0,0,0), but this var resolves to rgb(75,75,75) on light. Do we need to adjust the value of the var? Or is it just that we need to update our spectrum vars?
There was a problem hiding this comment.
update our spectrum vars
for any reviewers who don't already know, you can get the spectrum plugin for XD, then when you click on a component, it'll tell you the spectrum variable names. you can swap between version 5 and 6
There was a problem hiding this comment.
Is this the same issue I'm seeing where the sort direction indicator looks darker in the XD file and v5 colors says it should be #6d6d6, closest Spectrum being gray-700, but we're using #8e8e8e/rgb(142,142,142). When I look at the spectrum token of that color we're using gray-600, which isn't gray-700.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Where are the accordion XD files? I'm sure the larger and darker side is desired it just looks weird. I wanted to check the chevron because the open state seems too low. Probably not a priority since this is alpha and main work is being done by Quarry. |
| @@ -16,19 +16,20 @@ governing permissions and limitations under the License. | |||
| } | |||
|
|
|||
| .spectrum-Table-headCell { | |||
| color: var(--spectrum-table-header-text-color); | |||
| color: var(--spectrum-alias-text-color); | |||
There was a problem hiding this comment.
Is this the same issue I'm seeing where the sort direction indicator looks darker in the XD file and v5 colors says it should be #6d6d6, closest Spectrum being gray-700, but we're using #8e8e8e/rgb(142,142,142). When I look at the spectrum token of that color we're using gray-600, which isn't gray-700.
accordion xd are in the contributions site
Sort icon was wrong, should be gray-800 like the text, on hover they become gray-900 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Closes
One thing to note, on overflow wrap tables, the headers have now gotten taller by 4px because we start with an estimated height and then calculate after render the actual height.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: