Skip to content

Conversation

ktabors
Copy link
Member

@ktabors ktabors commented Sep 29, 2022

Closes

Chrome 105 had a crash with table and sticky. It's fixed in 106 so pinning the code to only 105.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

use chrome 105 and chrome 106
goto stories like many columns and rows and renderEmptyState where there is a checkbox in the header and scroll.
These stories should not break
In 105 the checkbox is not sticky, while in 106 it is.

🧢 Your Project:

RSP

@ktabors ktabors changed the title Chrome 105 sticky crashing pinned to v105 Chrome 105 TableView sticky crashing pinned to v105 Sep 29, 2022
@adobe-bot
Copy link

@devongovett devongovett merged commit f6f39ee into main Sep 29, 2022
@devongovett devongovett deleted the chrome_106_sticky branch September 29, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants