Skip to content

Add ActionBar examples to TableView and ListView docs #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 18, 2023
Merged

Add ActionBar examples to TableView and ListView docs #3777

merged 10 commits into from
Jan 18, 2023

Conversation

reidbarber
Copy link
Member

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger reviewed Nov 21, 2022
View reviewed changes
@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Nov 22, 2022
View reviewed changes
ktabors
ktabors reviewed Nov 22, 2022
View reviewed changes
@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Nov 22, 2022
View reviewed changes
ktabors
ktabors previously approved these changes Nov 22, 2022
View reviewed changes
@reidbarber reidbarber dismissed stale reviews from ktabors and snowystinger via f240910 November 22, 2022 17:57
@reidbarber
Copy link
Member Author

I've added a link to the ActionBar docs page, so this should get merged after #2777.

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

LFDanLu
LFDanLu approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbarber
Copy link
Member Author

Will merge after #2777

@rspbot
Copy link

rspbot commented Jan 18, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jan 18, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@reidbarber reidbarber merged commit 767a617 into main Jan 18, 2023
@reidbarber reidbarber deleted the add-actionbar-to-tableview-listview-docs branch January 18, 2023 22:30
LFDanLu added a commit that referenced this pull request Jan 18, 2023
@LFDanLu
Revert "Add ActionBar examples to TableView and ListView docs (#3777)"
f67bb84 
This reverts commit 767a617.
LFDanLu added a commit that referenced this pull request Jan 18, 2023
@LFDanLu
Revert Actionbar docs release (#3931)
5d773ee 
* Revert "Add ActionBar examples to TableView and ListView docs (#3777)"

This reverts commit 767a617.

* Revert "release actionbar docs (#3927)"

This reverts commit 29fbecf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@snowystinger snowystinger snowystinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reidbarber @adobe-bot @rspbot @ktabors @snowystinger @LFDanLu