Skip to content

Conversation

devongovett
Copy link
Member

This ensures that there is only ever a single LandmarkManager instance on the page, even if there are multiple copies or different versions loaded. This is necessary so their global keyboard listeners do not conflict.

It is implemented by attaching the current instance to the document under a hidden symbol. If multiple different versions are loaded, the newest one replaces the older ones. We must ensure that the minimal API in the LandmarkManagerApi and Landmark interfaces never contain breaking changes so that registering landmarks from an older version of useLandmark against a newer version of LandmarkManager continues to work.

'radix': [ERROR, 'always'],
'react/jsx-uses-react': WARN,
'eol-last': ERROR,
'arrow-body-style': [ERROR, 'as-needed'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in slack.

@rspbot
Copy link

rspbot commented Jan 26, 2023

@rspbot
Copy link

rspbot commented Jan 26, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@devongovett devongovett merged commit 75ca0e3 into main Jan 30, 2023
@devongovett devongovett deleted the landmark-singleton branch January 30, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants