Make LandmarkManager a global singleton #3966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that there is only ever a single
LandmarkManager
instance on the page, even if there are multiple copies or different versions loaded. This is necessary so their global keyboard listeners do not conflict.It is implemented by attaching the current instance to the
document
under a hidden symbol. If multiple different versions are loaded, the newest one replaces the older ones. We must ensure that the minimal API in theLandmarkManagerApi
andLandmark
interfaces never contain breaking changes so that registering landmarks from an older version ofuseLandmark
against a newer version ofLandmarkManager
continues to work.