Skip to content

Adding missing descriptions to TableColumnResizeAria #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Adding missing descriptions to TableColumnResizeAria #3992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10dd27f
Adding missing descriptions and removing extra stars
LFDanLu Jan 31, 2023
2909f66
Merge branch 'main' into more_updates
snowystinger Feb 1, 2023
26291a2
Merge branch 'main' into more_updates
LFDanLu Feb 1, 2023
0a647a2
Merge branch 'main' into more_updates
LFDanLu Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@react-aria/table/src/useTableColumnResize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ import {useKeyboard, useMove, usePress} from '@react-aria/interactions';
import {useLocale, useLocalizedStringFormatter} from '@react-aria/i18n';

export interface TableColumnResizeAria {
/** Props for the visually hidden input element. */
inputProps: DOMAttributes,
/** Props for the resizer element. */
resizerProps: DOMAttributes
}

Expand Down
4 changes: 2 additions & 2 deletions packages/@react-stately/table/src/useTableColumnResizeState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface TableColumnResizeStateProps<T> {
/**
* Current width of the table or table viewport that the columns
* should be calculated against.
**/
*/
tableWidth: number,
/** A function that is called to find the default width for a given column. */
getDefaultWidth?: (node: GridNode<T>) => ColumnSize | null | undefined,
Expand All @@ -31,7 +31,7 @@ export interface TableColumnResizeState<T> {
/**
* Called to update the state that a resize event has occurred.
* Returns the new widths for all columns based on the resized column.
**/
*/
onColumnResize: (key: Key, width: number) => Map<Key, ColumnSize>,
/** Callback for when onColumnResize has started. */
onColumnResizeStart: (key: Key) => void,
Expand Down