Skip to content

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Feb 10, 2023

Closes #4043

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 10, 2023

Copy link
Collaborator

@majornista majornista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've committed suggested changes: 5072c33

@rspbot
Copy link

rspbot commented Feb 13, 2023

Copy link
Collaborator

@majornista majornista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes I committed.

@majornista majornista self-requested a review February 14, 2023 14:38
@snowystinger snowystinger changed the title Add aria-label to badge story Add aria-label to badge story and docs Feb 14, 2023
@rspbot
Copy link

rspbot commented Feb 14, 2023

@rspbot
Copy link

rspbot commented Feb 14, 2023

@rspbot
Copy link

rspbot commented Feb 14, 2023

@rspbot
Copy link

rspbot commented Feb 14, 2023

@rspbot
Copy link

rspbot commented Feb 14, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@dannify dannify merged commit f847cd0 into main Feb 14, 2023
@dannify dannify deleted the add-aria-label-to-badge-story branch February 14, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge: Icon Only variant in storybook does not have aria-label.

5 participants