Skip to content

Conversation

reidbarber
Copy link
Member

From audit

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 13, 2023

@rspbot
Copy link

rspbot commented Feb 13, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@react-aria/tag

useTag

 useTag<T> {
   props: TagProps<T>
   state: TagGroupState<T>
+  ref: RefObject<FocusableElement>
   returnVal: undefined
 }

TagProps

 TagProps<T> {
   allowsRemoving?: boolean
   isFocused: boolean
   item: Node<T>
   onRemove?: (Key) => void
-  tagRowRef: RefObject<HTMLElement>
 }

@reidbarber reidbarber merged commit 6013307 into main Feb 13, 2023
@reidbarber reidbarber deleted the tag-ref-fix branch February 13, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants