Skip to content

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 15, 2023

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Feb 15, 2023

Build successful! 🎉

* [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/7cf1fcb579018d5af830b57e3df9039d59a89a96/storybook/index.html)
* [View the storybook-17](https://reactspectrum.blob.core.windows.net/reactspectrum/7cf1fcb579018d5af830b57e3df9039d59a89a96/storybook-17/index.html)
* [View the storybook-16](https://reactspectrum.blob.core.windows.net/reactspectrum/7cf1fcb579018d5af830b57e3df9039d59a89a96/storybook-16/index.html)
* [View the documentation](https://reactspectrum.blob.core.windows.net/reactspectrum/7cf1fcb579018d5af830b57e3df9039d59a89a96/docs/index.html)

@rspbot
Copy link

rspbot commented Feb 15, 2023

@LFDanLu LFDanLu changed the title (WIP) Add more info for comment workflow Add more info for PR comment workflow Feb 15, 2023
@LFDanLu LFDanLu changed the title Add more info for PR comment workflow Add more debug info for PR comment workflow Feb 15, 2023
});
});
} catch (err) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console log the err?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh what da heck, I swear I had a console.error here

@rspbot
Copy link

rspbot commented Feb 15, 2023

@rspbot
Copy link

rspbot commented Feb 15, 2023

@rspbot
Copy link

rspbot commented Feb 15, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@LFDanLu LFDanLu merged commit e9f0817 into main Feb 15, 2023
@LFDanLu LFDanLu deleted the GET_BUILD_debug branch February 15, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants