fix(#4190): useLabels/useLabel consider reordering IDREFs so that aria-label comes before aria-labelledby #4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
requested review from
devongovett,
ktabors,
snowystinger,
reidbarber,
LFDanLu and
dannify
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
added 4 commits
May 17, 2023 13:03
…a-label comes before aria-labelledby
Add commas, so that date segments will have more space to distinguish between the various ways in which they are labeled. For example: "3 – March, month, Start date, Date range, stepper, Date range, group" instead of: "3 – March, Date range Start date month, stepper, Date range, group"
majornista
force-pushed
the
4190-uselabelsuselabel-consider-reordering-idrefs-so-that-aria-label-comes-before-aria-labelledby
branch
from
840ae6d to
dfecc40
Compare
|
Build successful! 🎉 |
…drefs-so-that-aria-label-comes-before-aria-labelledby
|
Build successful! 🎉 |
…drefs-so-that-aria-label-comes-before-aria-labelledby
|
Build successful! 🎉 |
snowystinger
approved these changes
May 26, 2023
…drefs-so-that-aria-label-comes-before-aria-labelledby
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
@snowystinger Thanks for the commit, removing my over-engineering in the tests, and for your approval. |
…drefs-so-that-aria-label-comes-before-aria-labelledby
|
Build successful! 🎉 |
LFDanLu
approved these changes
May 26, 2023
…drefs-so-that-aria-label-comes-before-aria-labelledby
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
snowystinger
deleted the
4190-uselabelsuselabel-consider-reordering-idrefs-so-that-aria-label-comes-before-aria-labelledby
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4190
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Adobe/Accessibility