Skip to content

Conversation

devongovett
Copy link
Member

Depends on #4212.

  • Fixes animation issue with Select popover
  • Switches to using --trigger-width as a CSS custom property for both ComboBox and Select popovers for consistency
  • Fixes animation of side modal example in Chrome, which previously got stuck open. This was due to an ordering issue where child animations completed before parents.
  • Fix all docs examples with select all from displaying a,l,l
  • Fix question mark in circle character on Windows - switched to i in circle. No font seems to support the question mark.
  • Fixed some high contrast styling
  • Fixes isFocused in useOption to only be true when the collection is actually focused.
  • Added an isFocusVisible return value to useOption which works with virtual focus, and allows us to get rid of another dependency in aria components. Closes Doc Issue: useFocusRing differs between Listbox Option in useComboBox and useListbox docs #4163.

@rspbot
Copy link

rspbot commented Mar 17, 2023

snowystinger
snowystinger previously approved these changes Mar 17, 2023
reidbarber
reidbarber previously approved these changes Mar 17, 2023
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from aria-component-docs-ts to main March 17, 2023 23:42
@devongovett devongovett dismissed stale reviews from reidbarber and snowystinger via 7a0c4bb March 17, 2023 23:45
@devongovett devongovett force-pushed the aria-components-fixes branch from dc7763a to 7a0c4bb Compare March 17, 2023 23:45
@rspbot
Copy link

rspbot commented Mar 17, 2023

@rspbot
Copy link

rspbot commented Mar 17, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@react-aria/listbox

AriaOptionProps

 OptionAria {
   descriptionProps: DOMAttributes
+  isFocusVisible: boolean
   isFocused: boolean
   labelProps: DOMAttributes
   optionProps: DOMAttributes
 }

it changed:

  • useOption

@devongovett devongovett merged commit 29d52d7 into main Mar 18, 2023
@devongovett devongovett deleted the aria-components-fixes branch March 18, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc Issue: useFocusRing differs between Listbox Option in useComboBox and useListbox docs
4 participants