Skip to content

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Mar 24, 2023

prevents specificity war between the icon own height/width and the one dictated by the textfield. Discovered via chromatic

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

LFDanLu added 2 commits March 23, 2023 16:59
prevents specificity war between the icon own height/width and the one dictated by the textfield
@LFDanLu LFDanLu added the small review Easy to review PR label Mar 24, 2023
@rspbot
Copy link

rspbot commented Mar 24, 2023

@rspbot
Copy link

rspbot commented Mar 24, 2023

snowystinger
snowystinger previously approved these changes Mar 24, 2023
devongovett
devongovett previously approved these changes Mar 24, 2023
@LFDanLu
Copy link
Member Author

LFDanLu commented Mar 24, 2023

hold off on merging, chromatic caught some weirdness that I can't reproduce locally yet bleh

@LFDanLu
Copy link
Member Author

LFDanLu commented Mar 24, 2023

Ah I'll fix that in this PR as well then

@LFDanLu LFDanLu dismissed stale reviews from devongovett and snowystinger via b602f6a March 24, 2023 01:00
@LFDanLu
Copy link
Member Author

LFDanLu commented Mar 24, 2023

I've updated the search autocomplete input so that it looks like the input within the MobileComboBox tray (aka icon + loading spinner is placed before the 'x') This means the x is persisted when there is a spinner/validation icon to avoid an awkward empty space after :
image
image

Alternatively, I could remove the spectrum-Search--loadable and make it look like the following which is closer to its original form but IMO a bit worse looking:
image
image

@LFDanLu LFDanLu changed the title Increase specificity of textfield icon Increase specificity of textfield icon and fix search autocomplete styling Mar 24, 2023
@rspbot
Copy link

rspbot commented Mar 24, 2023

@rspbot
Copy link

rspbot commented Mar 24, 2023

@LFDanLu
Copy link
Member Author

LFDanLu commented Mar 27, 2023

@rspbot
Copy link

rspbot commented Mar 27, 2023

@rspbot
Copy link

rspbot commented Mar 27, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@LFDanLu LFDanLu merged commit db4c617 into main Mar 27, 2023
@LFDanLu LFDanLu deleted the specificity branch March 27, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants