Skip to content

fix(#4317): LabeledValue: ContextualHelp button should be labeled by the label #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 26, 2023
Merged

fix(#4317): LabeledValue: ContextualHelp button should be labeled by the label #4319

merged 7 commits into from
May 26, 2023

Conversation

majornista
Copy link
Collaborator

Closes #4317

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue #4371.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Adobe/Accessibility

@rspbot
Copy link

rspbot commented Mar 31, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 15, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 17, 2023

Build successful! 🎉

snowystinger
snowystinger approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems pretty specific to our RSP setup, so seems reasonable to put the fallback here

@rspbot
Copy link

rspbot commented May 25, 2023

Build successful! 🎉

@snowystinger snowystinger added the small review Easy to review PR label May 25, 2023
@rspbot
Copy link

rspbot commented May 26, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 26, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 26, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 26, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger snowystinger merged commit 5c64bcb into main May 26, 2023
@snowystinger snowystinger deleted the LabeledValue-ContextualHelp branch May 26, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

@devongovett devongovett Awaiting requested review from devongovett

@reidbarber reidbarber Awaiting requested review from reidbarber

@ktabors ktabors Awaiting requested review from ktabors

@dannify dannify Awaiting requested review from dannify

Assignees
No one assigned
Labels
accessibility bug Something isn't working rsp:LabeledValue small review Easy to review PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LabeledValue: ContextualHelp button should be labeled by the label
5 participants
@majornista @rspbot @snowystinger @LFDanLu @yihuiliao