Add useEffectEvent shim for easier strictmode development #4345
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
changed the title
devongovett
reviewed
Apr 11, 2023
snowystinger
changed the title
|
Build successful! 🎉 |
LFDanLu
approved these changes
Apr 11, 2023
devongovett
approved these changes
Apr 12, 2023
devongovett
reviewed
Apr 12, 2023
| import {useCallback, useRef} from 'react'; | ||
| import {useLayoutEffect} from './useLayoutEffect'; | ||
|
|
||
| export function useEffectEvent(fn) { |
There was a problem hiding this comment.
This should probably have a type.
There was a problem hiding this comment.
Good call, I'll add it in a PR where I use it. I think I'm going to do NumberField first
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } @react-aria/utilsisVirtualPointerEvent-
+useEffectEvent {
+ fn: any
+ returnVal: undefined
+} |
cgood92
pushed a commit
to cgood92/react-spectrum
that referenced
this pull request
May 9, 2023
* Add useEffectEvent shim for easier strictmode development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Is this where we want the code to live?
If it does, useLayoutEffect technically isn't ok in the stately package, so I'd need to move that in here as well
I can't quite tell if we'd need to use this in a stately package or only aria and up.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: