Skip to content

Conversation

reidbarber
Copy link
Member

  • Fixes background to match Spectrum designs
  • Removes extra stories
  • Adds dynamic story, and adds to Form story
  • Updates some 'In-line' in descriptions to 'Inline' to match docs

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@reidbarber reidbarber changed the title InlineAlert: Fix background and cleanup stories InlineAlert: Fix background color and clean up stories May 31, 2023
<Form onSubmit={handleSubmit} isReadOnly={formStatus === 'valid'}>
{(formStatus === 'invalid' || formStatus === 'valid') &&
<InlineAlert variant={formStatus === 'invalid' ? 'negative' : 'positive'}>
<Header>{formStatus === 'invalid' ? 'Error' : 'Success'}</Header>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only "concern" is that when the Header text is the same as the variant string it says the same word twice. That is an issue for the developing team... wondering if we'll get complaints.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think apps should hopefully use more specific titles.

@rspbot
Copy link

rspbot commented May 31, 2023

@rspbot
Copy link

rspbot commented May 31, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@reidbarber reidbarber merged commit b1545c0 into main Jun 1, 2023
@reidbarber reidbarber deleted the inline-alert-fixes branch June 1, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants