Skip to content

Conversation

ktabors
Copy link
Member

@ktabors ktabors commented Jun 3, 2023

#followup

Moved the translations into a single file to prevent them from getting real translations.
Adding a description to the stories to help testers know what languages have translations.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jun 3, 2023

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked out the stories and everything seems to be good

@rspbot
Copy link

rspbot commented Jun 9, 2023

@rspbot
Copy link

rspbot commented Jun 9, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@ktabors ktabors merged commit f6d37e1 into main Jun 9, 2023
@ktabors ktabors deleted the translation_stories_followup branch June 9, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants