Skip to content

Conversation

ktabors
Copy link
Member

@ktabors ktabors commented Jul 20, 2023

Closes #4105

Fixing fill style for HCM ProgressBar and adding support for overBackground and Meter fill colors.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check the ProgressBar and Meter in HCM to confirm fill is properly overridden.

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jul 20, 2023

@rspbot
Copy link

rspbot commented Jul 20, 2023

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rspbot
Copy link

rspbot commented Jul 21, 2023

@rspbot
Copy link

rspbot commented Jul 21, 2023

@rspbot
Copy link

rspbot commented Jul 21, 2023

@rspbot
Copy link

rspbot commented Jul 21, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@ktabors ktabors merged commit c60c872 into main Jul 21, 2023
@ktabors ktabors deleted the hcm_barloader branch July 21, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressBar/Meter: In HCM, fill color is not being picked from forced-colors media query
5 participants