Skip to content

Conversation

reidbarber
Copy link
Member

Closes #4141

In SearchField, SearchAutocomplete, Mobile SearchAutocomplete, and MobileCombobox, the clear button should keep a transparent background in High Contrast Mode, so that it's background doesn't overlap surrounding elements. This helps prevent the following:

Screenshot 2023-07-20 at 5 49 54 PM

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check clear button in HCM in SearchField, SearchAutocomplete, Mobile SearchAutocomplete, and MobileCombobox components.

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jul 20, 2023

@rspbot
Copy link

rspbot commented Jul 21, 2023

@rspbot
Copy link

rspbot commented Jul 21, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@reidbarber reidbarber merged commit 57defbd into main Jul 21, 2023
@reidbarber reidbarber deleted the hcm-fix-clearbutton branch July 21, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

searchField: clear button issues in High Contrast mode
4 participants