Fixing various documentation typos #4827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lreis
changed the title
|
GET_BUILD |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
devongovett
approved these changes
Aug 1, 2023
ktabors
reviewed
Aug 1, 2023
| @@ -294,7 +294,7 @@ Some time values during daylight saving transitions may be _ambiguous_. For exam | |||
| // A "spring forward" transition | |||
| let date = new CalendarDateTime(2020, 3, 8, 2); | |||
| date.toDate('America/Los_Angeles', 'earlier'); | |||
| // => Sun Mar 08 2020 03:00:00 GMT-0800 (Pacific Daylight Time) | |||
| // => Sun Mar 08 2020 01:00:00 GMT-0800 (Pacific Daylight Time) | |||
There was a problem hiding this comment.
Suggested change
| // => Sun Mar 08 2020 01:00:00 GMT-0800 (Pacific Daylight Time) | |
| // => Sun Mar 08 2020 01:00:00 GMT-0800 (Pacific Standard Time) |
Your issue listed this change, and I confirmed it, but it was left out.
There was a problem hiding this comment.
@ktabors Thanks for catching this. I'll include it in my next documentation-related PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4826 - @internationalized documentation typos
✅ Pull Request Checklist:
🧢 Your Project:
Adobe Globalization team - internal I18n audit