Adding feature flag check for expandable table rows in aria hooks #4865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
commented
Aug 4, 2023
| rowProps['aria-rowindex'] = node.index + 1 + state.collection.headerRows.length; // aria-rowindex is 1 based | ||
| } else { | ||
| delete rowProps['aria-rowindex']; | ||
| } | ||
|
|
||
| let treeGridRowProps: HTMLAttributes<HTMLElement> = {}; | ||
| if ('expandedKeys' in state) { | ||
| if (tableNestedRows() && 'expandedKeys' in state) { |
There was a problem hiding this comment.
wanted to just make a var for let isTreeGrid = tableNestedRows() && 'expandedKeys' in state; and use it here, but typescript wasn't smart enough to figure out that state would then be a TreeGridState only and complained about lines below
|
Build successful! 🎉 |
reidbarber
approved these changes
Aug 4, 2023
devongovett
approved these changes
Aug 4, 2023
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP