Skip to content

Conversation

devongovett
Copy link
Member

Fixes popover positioning with contextual help trigger, and left/right placement.

@rspbot
Copy link

rspbot commented Sep 29, 2023

@rspbot
Copy link

rspbot commented Sep 29, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested usePopover and Menu Item unavailable in docs and storybook

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested docs popovers for RSP, React Aria, and RAC LGTM. Storybook stories look good at various offsets/placement options as well. Chromatic ran clean as well

@devongovett devongovett merged commit 3d2de0e into main Sep 29, 2023
@devongovett devongovett deleted the fix-overlay-position branch September 29, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants