Skip to content

Conversation

andrewchough
Copy link
Contributor

Closes #4954

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

yarn test / npm run test

🧢 Your Project:

Recordings

Before
https://github.com/adobe/react-spectrum/assets/8335579/37fd8f71-f91b-4448-9ac0-968858094503

After
https://github.com/adobe/react-spectrum/assets/8335579/5ccbf407-fbd7-44e4-b14d-19d95d7b61d0

@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Oct 7, 2023

@rspbot
Copy link

rspbot commented Oct 7, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger
Copy link
Member

your description says to test the change by running tests

yarn test / npm run test

however, I don't see any tests/checks added in the PR, did you mean to push some up? it'd be much appreciated https://react-spectrum.adobe.com/contribute.html#pull-requests

otherwise the changes look good

@snowystinger snowystinger added the waiting Waiting on Issue Author label Oct 16, 2023
@snowystinger snowystinger removed the waiting Waiting on Issue Author label Oct 24, 2023
@andrewchough andrewchough force-pushed the passOnPressUpToUsePress branch from 9cd79f0 to b67c7f8 Compare October 24, 2023 15:56
@reidbarber reidbarber merged commit 19befac into adobe:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onPressUp and onPressDown are listed as props, but they are not used in useButton
5 participants