Skip to content

Conversation

aratahikaru5
Copy link
Contributor

Closes #5249

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • n/a Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • n/a Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • n/a Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

n/a

🧢 Your Project:

n/a

@snowystinger
Copy link
Member

This looks correct, thanks for submitting a PR. Would you mind signing the CLA? https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement You may need to close the PR and reopen it to get it to take effect

@aratahikaru5
Copy link
Contributor Author

I've signed the CLA and re-triggered the check.

@reidbarber
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Oct 16, 2023

@rspbot
Copy link

rspbot commented Oct 16, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihuiliao yihuiliao merged commit d9d7ec9 into adobe:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAC: incorrect prop is destructured in SearchField documentation
5 participants