Skip to content

Conversation

snowystinger
Copy link
Member

Closes #5499

This would probably have been found by TS Strictmode when we turned it on for this file. I verified this in
https://stackblitz.com/edit/stackblitz-starters-sjybxv it was just a random stackblitz I found with nextjs. All that mattered was that the warning appeared, not how pretty it was. It could probably be verified in our examples too.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 30, 2023

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably fine, but I don't think we have a RAC table w/ column resizing in the test NextJS app

@snowystinger
Copy link
Member Author

this is probably fine, but I don't think we have a RAC table w/ column resizing in the test NextJS app

Yeah, our next apps are all react-spectrum at the moment and this change seems quite small and innocuous. I tested it using the stackblitz I mentioned earlier, and I'm pretty confident it'd have been caught by TS strict

@rspbot
Copy link

rspbot commented Dec 11, 2023

@rspbot
Copy link

rspbot commented Dec 12, 2023

@rspbot
Copy link

rspbot commented Dec 12, 2023

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@snowystinger snowystinger merged commit 948557c into main Dec 12, 2023
@snowystinger snowystinger deleted the fix-table-warning-in-nextjs branch December 12, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Received NaN for the max attribute. If this is expected, cast the value to a string.
4 participants