Skip to content

Conversation

ryo-manba
Copy link
Contributor

@ryo-manba ryo-manba commented Jan 11, 2024

Closes #4895

The fix ensures that when rowHeader is not present, the drag preview displays the content of the first element, excluding checkboxes and dragButtons.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Visit http://localhost:9003/?path=/story/tableview-drag-and-drop--drag-out-of-table-without-table-header&args=selectionStyle:highlight&providerSwitcher-express=false&strict=true
  2. In the Table, drag a row.
  3. Verify that the text from the first column ("First name") of the dragged row is displayed in the drag preview.

🧢 Your Project:

@ryo-manba ryo-manba changed the title Fix drag preview in TableView Fix drag preview not displaying text in TableView Jan 11, 2024
@snowystinger
Copy link
Member

GET_BUILD

Copy link

@haevensk haevensk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers all test cases and complies with best practice ⭐ Great job on this @ryo-manba

@rspbot
Copy link

rspbot commented Jan 11, 2024

@rspbot
Copy link

rspbot commented Jan 11, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@reidbarber reidbarber merged commit c3a4d63 into adobe:main Jan 11, 2024
@ryo-manba ryo-manba deleted the fix/table-drag-preview branch January 12, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableView DnD DragPreview does not render text
5 participants