-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Docs for addWindowFocusTracking #5851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments, content looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me just one comment but feel free to merge as is
<PageDescription>{docs.exports.addWindowFocusTracking.description}</PageDescription> | ||
<FunctionAPI function={docs.exports.addWindowFocusTracking} links={docs.links} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does <TypeLink>
work here? IMO it would be nice to have the function be mentioned inline in the paragraph if so (maybe where "function" is at the moment).
One kinda outstanding question. Is it weird to call the function with an element inside the iframe? as opposed to having people get the ownerDocument themselves? the name ends up a little odd in my opinion, but I haven't thought of anything better yet. |
Build successful! 🎉 |
Looking into only exposing docs via jsdocs and not on the official docs website because we don't have our own use cases for this, meaning that it's still experimental. This should still show up in IDE's. |
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: