-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListBox (grid layout) keyboard navigation TypeError #6172
Conversation
GET_BUILD |
Build successful! 🎉 |
I'm unable to see this happening in the docs. Anything I need to do other than:
EDIT: Nevermind, I just needed to look in the console. Thank you! |
GET_BUILD |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #6168
While fixing the bug, I've noticed a horizontal grid ListBox also has the same issue when navigating left and right via keyboard ('arrowLeft' and 'arrowRight'). Included unit test covers both cases.
By the way, these bugs can be seen in the docs as well
✅ Pull Request Checklist:
📝 Test Instructions:
Story
🧢 Your Project: