Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListBox (grid layout) keyboard navigation TypeError #6172

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

sookmax
Copy link
Contributor

@sookmax sookmax commented Apr 8, 2024

Closes #6168

While fixing the bug, I've noticed a horizontal grid ListBox also has the same issue when navigating left and right via keyboard ('arrowLeft' and 'arrowRight'). Included unit test covers both cases.

By the way, these bugs can be seen in the docs as well

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Story

🧢 Your Project:

snowystinger

This comment was marked as duplicate.

@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Apr 9, 2024

@snowystinger
Copy link
Member

snowystinger commented Apr 9, 2024

By the way, these bugs can be seen in the docs as well

I'm unable to see this happening in the docs. Anything I need to do other than:

  1. tab to example
  2. arrow key off the side in any direction

EDIT: Nevermind, I just needed to look in the console. Thank you!

@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Apr 10, 2024

@rspbot
Copy link

rspbot commented Apr 10, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbarber reidbarber merged commit b8f421a into adobe:main Apr 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListBox with layout="grid" throws exceptions when navigated out of bounds via keyboard
5 participants