Skip to content

Conversation

teemuandersen
Copy link
Contributor

@teemuandersen teemuandersen commented Sep 3, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

It is kinda hard to reproduce the issue, but can't figure out how this null check could do any harm.

@snowystinger
Copy link
Member

Thanks for the PR, you'll need to sign the CLA https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement
Then you may need to close and reopen the PR to get it to take hold.

@LFDanLu LFDanLu merged commit 53413af into adobe:main Sep 19, 2024
29 checks passed
@teemuandersen teemuandersen deleted the Fix-useDateSegment-null-ref-6988 branch September 20, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useDateSegment crashes on null reference during unmount
4 participants