Skip to content

chore: fix chromatic stories + add ToggleButtonGroup and ActionButtonGroup to chromatic #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 9, 2024
Merged

chore: fix chromatic stories + add ToggleButtonGroup and ActionButtonGroup to chromatic #7335

merged 8 commits into from
Nov 9, 2024

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Nov 7, 2024 •
edited
Loading

  • adds ToggleButtonGroup to chromatic
  • adds ActionButtonGroup to chromatic
  • only applies flexShrink: 0 when toggle buttons or action buttons are in their respective groups
  • fixes segmented control custom width chromatic story by making it justified. also updates the name of this chromatic story

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@yihuiliao
Copy link
Member Author

yihuiliao commented Nov 7, 2024 •
edited
Loading

link to chromatic

i've update the name of segmented control: custom width after running chromatic cause it's not really an accurate representation of this story

snowystinger
snowystinger reviewed Nov 7, 2024
View reviewed changes
@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Nov 7, 2024

Build successful! 🎉

@yihuiliao yihuiliao added this pull request to the merge queue Nov 9, 2024
Merged via the queue into main with commit 3f67667 Nov 9, 2024
30 checks passed
@yihuiliao yihuiliao deleted the fix-chromatic branch November 9, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuiliao @rspbot @snowystinger @reidbarber