Skip to content

fix: remove z-index from SegmentedControl text #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: remove z-index from SegmentedControl text #7355

merged 1 commit into from
Nov 12, 2024

Conversation

reidbarber
Copy link
Member

Fixes case where Segmented Control text was showing above any Dialog open on top of it.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 11, 2024

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 7aa6265 Nov 12, 2024
30 checks passed
@reidbarber reidbarber deleted the segmented-control-z-index branch November 12, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@snowystinger snowystinger snowystinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbarber @rspbot @ktabors @snowystinger