Skip to content

Use selection manager isSelected method to check if menuitem is selected #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

jluyau
Copy link
Member

@jluyau jluyau commented Jul 18, 2020

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Create a menu with selectedKeys defined but no selectionMode prop and see that no items are selected

🧢 Your Project:

Adobe

@jluyau jluyau marked this pull request as ready for review July 20, 2020 18:35
@devongovett devongovett merged commit cdb915d into adobe:main Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants