Skip to content

fix: Ensure renderEmtpyState is properly displayed in V3 TableView #8416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix: Ensure renderEmtpyState is properly displayed in V3 TableView #8416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@react-spectrum/table/src/TableViewLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export class TableViewLayout<T> extends TableLayout<T> {
let empty = new LayoutInfo('empty', 'empty', rect);
empty.parentKey = layoutInfo.key;
empty.isSticky = true;
empty.allowOverflow = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had we accidentally removed this? or what happened? the issue looks familiar, so just want to make sure we aren't reintroducing some other issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I could tell via my digging, I think we just accidentally removed it. This break originates from this larger refactor: #6451 (and specifically https://github.com/adobe/react-spectrum/pull/6451/files#diff-d0c8a9ca3c72c8c8d461ad870324b199b779e399511a4aab54eb42ce3472820eL288-L293 I think) which had other similar overflow fixes caught and fixed via #6711. This specific one seems to have slipped through the cracks

let node = {
layoutInfo: empty,
validRect: empty.rect
Expand Down