chore: export isRTL utility function #8619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
approved these changes
Jul 23, 2025
| @@ -18,6 +18,7 @@ export {useDateFormatter} from './useDateFormatter'; | |||
| export {useNumberFormatter} from './useNumberFormatter'; | |||
| export {useCollator} from './useCollator'; | |||
| export {useFilter} from './useFilter'; | |||
| export {isRTL} from './utils'; | |||
There was a problem hiding this comment.
Seems fine, however, i was looking at their example, couldn't they just move the i18n provider outside of the html element then consume useLocale to get the direction? then there's no worry about it not updating accidentally or something like that?
snowystinger
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6985
seems like we said it was okay some time ago? i don't really remember the conversation tho lol
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: