Skip to content

docs(Toast): clarify toast close button placement #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

docs(Toast): clarify toast close button placement #8923

merged 1 commit into from
Sep 24, 2025
+1 −1

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Sep 24, 2025 •
edited
Loading

Closes #8679

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 24, 2025

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit b187771 Sep 24, 2025
33 checks passed
@reidbarber reidbarber deleted the toats-clarify-docs branch September 24, 2025 22:28
dkario pushed a commit to dkario/react-spectrum that referenced this pull request Sep 24, 2025
@reidbarber
docs: clarify toast close button placement (adobe#8923)
507fc19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify required placement of Toast close button and consider allowing it within ToastContent
4 participants
@reidbarber @rspbot @snowystinger @yihuiliao