Skip to content

chore: add missing placeholders to test apps and stories #8949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2025
Merged

chore: add missing placeholders to test apps and stories #8949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aeda3b
chore: add missing placeholders to test apps and stories
LFDanLu Sep 30, 2025
01f6bd9
Merge branch 'main' of github.com:adobe/react-spectrum into add_place…
LFDanLu Sep 30, 2025
1d72c2b
add placeholders to next app
yihuiliao Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/s2-next-macros/src/app/Lazy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export default function Lazy() {
return (
<>
<Section title="Color">
<ColorField label="Primary Color" />
<ColorField placeholder="-" label="Primary Color" />
<ColorSwatchPicker>
<ColorSwatch color="#A00" />
<ColorSwatch color="#f80" />
Expand Down Expand Up @@ -153,16 +153,16 @@ export default function Lazy() {
<Checkbox value="baseball">Baseball</Checkbox>
<Checkbox value="basketball">Basketball</Checkbox>
</CheckboxGroup>
<NumberField label="Width" defaultValue={1024} minValue={0} />
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
<RadioGroup label="Favorite pet">
<Radio value="dogs">Dogs</Radio>
<Radio value="cats">Cats</Radio>
</RadioGroup>
<SearchField label="Search" />
<Switch>Low power mode</Switch>
<TextArea label="Description" />
<TextField label="Email" />
<TextField label="Password" />
<TextArea placeholder="Enter a description" label="Description" />
<TextField placeholder="Enter a email" label="Email" />
<TextField placeholder="Enter a password" label="Password" />
<SelectBoxGroup aria-label="Choose a cloud">
<SelectBox id="aws" textValue="Amazon Web Services">
<Server />
Expand Down Expand Up @@ -359,7 +359,7 @@ export default function Lazy() {
</Section>

<Section title="Pickers">
<ComboBox label="Favorite Animal">
<ComboBox placeholder="Select a value" label="Favorite Animal">
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
<ComboBoxItem id="cat">Cat</ComboBoxItem>
<ComboBoxItem id="dog">Dog</ComboBoxItem>
Expand Down
12 changes: 6 additions & 6 deletions examples/s2-parcel-example/src/Lazy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default function Lazy() {
return (
<>
<Section title="Color">
<ColorField label="Primary Color" />
<ColorField placeholder="-" label="Primary Color" />
<ColorSwatchPicker>
<ColorSwatch color="#A00" />
<ColorSwatch color="#f80" />
Expand Down Expand Up @@ -139,16 +139,16 @@ export default function Lazy() {
<Checkbox value="baseball">Baseball</Checkbox>
<Checkbox value="basketball">Basketball</Checkbox>
</CheckboxGroup>
<NumberField label="Width" defaultValue={1024} minValue={0} />
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
<RadioGroup label="Favorite pet">
<Radio value="dogs">Dogs</Radio>
<Radio value="cats">Cats</Radio>
</RadioGroup>
<SearchField label="Search" />
<Switch>Low power mode</Switch>
<TextArea label="Description" />
<TextField label="Email" />
<TextField label="Password" />
<TextArea placeholder="Enter a description" label="Description" />
<TextField placeholder="Enter a email" label="Email" />
<TextField placeholder="Enter a password" label="Password" />
<SelectBoxGroup aria-label="Choose a cloud">
<SelectBox id="aws" textValue="Amazon Web Services">
<Server />
Expand Down Expand Up @@ -345,7 +345,7 @@ export default function Lazy() {
</Section>

<Section title="Pickers">
<ComboBox label="Favorite Animal">
<ComboBox placeholder="Select a value" label="Favorite Animal">
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
<ComboBoxItem id="cat">Cat</ComboBoxItem>
<ComboBoxItem id="dog">Dog</ComboBoxItem>
Expand Down
12 changes: 6 additions & 6 deletions examples/s2-webpack-5-example/src/Lazy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default function Lazy() {
return (
<>
<Section title="Color">
<ColorField label="Primary Color" />
<ColorField placeholder="-" label="Primary Color" />
<ColorSwatchPicker>
<ColorSwatch color="#A00" />
<ColorSwatch color="#f80" />
Expand Down Expand Up @@ -139,16 +139,16 @@ export default function Lazy() {
<Checkbox value="baseball">Baseball</Checkbox>
<Checkbox value="basketball">Basketball</Checkbox>
</CheckboxGroup>
<NumberField label="Width" defaultValue={1024} minValue={0} />
<NumberField placeholder="Enter a width" label="Width" defaultValue={1024} minValue={0} />
<RadioGroup label="Favorite pet">
<Radio value="dogs">Dogs</Radio>
<Radio value="cats">Cats</Radio>
</RadioGroup>
<SearchField label="Search" />
<Switch>Low power mode</Switch>
<TextArea label="Description" />
<TextField label="Email" />
<TextField label="Password" />
<TextArea placeholder="Enter a description" label="Description" />
<TextField placeholder="Enter a email" label="Email" />
<TextField placeholder="Enter a password" label="Password" />
<SelectBoxGroup aria-label="Choose a cloud">
<SelectBox id="aws" textValue="Amazon Web Services">
<Server />
Expand Down Expand Up @@ -345,7 +345,7 @@ export default function Lazy() {
</Section>

<Section title="Pickers">
<ComboBox label="Favorite Animal">
<ComboBox placeholder="Select a value" label="Favorite Animal">
<ComboBoxItem id="red panda">Red Panda</ComboBoxItem>
<ComboBoxItem id="cat">Cat</ComboBoxItem>
<ComboBoxItem id="dog">Dog</ComboBoxItem>
Expand Down