Use inline styles in VisuallyHidden instead of importing CSS #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
snowystinger
reviewed
Aug 7, 2020
| className | ||
| ); | ||
| let [isFocused, setFocused] = useState(false); | ||
| let {focusProps} = useFocus({ |
There was a problem hiding this comment.
should useFocus return isFocused as well, like the useHover hook?
There was a problem hiding this comment.
ehh maybe a separate task. Not sure whether we want to add state to every call to useFocus though
dannify
approved these changes
Aug 11, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861.
This removes the CSS import from
@react-aria/visually-hiddenand uses inline styles instead. Unfortunately, due to theisFocusableprop, we have to also add dependencies on@react-aria/interactionsforuseFocusand@react-aria/utilsformergePropsbecause you cannot have a:focusselector on an inline style. We don't currently use theisFocusableprop anywhere, but in order to maintain semver compatibility we cannot drop it. Luckily, in most cases, these functions will already be dependencies of anything that usesVisuallyHidden. We can look at dropping theisFocusableprop in the next major though.