-
Notifications
You must be signed in to change notification settings - Fork 207
fix(radio): correct display of read-only state #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2261d0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3350--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.26 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsradio
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! I just had a few suggestions after wrapping up with the related checkbox work:
…kles/css-1005-radio-readonly-refactor
…kles/css-1005-radio-readonly-refactor
Description
Same motivation as CSS-1004 for read-only checkbox, as being updated in PR #3328
Field group:
Radio:
disabled
attribute removed when read-only. Read-only still needs to be focusable / in the tab orderaria-disabled="true"
to not announce as interactive by screen readers (ex. "dimmed" in VO)aria-readonly
had no effect on radio buttons, or even when set onrole="radiogroup"
at least in VO, but left in case other AT make use of itHow and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
@jawinn
Regression testing
Expected changes:
Validate:
Screenshots
Before:

After:

To-do list