Skip to content

fix(lint-staged): remove conflicting flag for prettier command #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Jul 15, 2025

Description

This fixes the prettier portion of our lint stage hooked by removing the --no-config flag that conflicts with the final --config .prettierrc flag.

How and where has this been tested?

Verified by removing the flag in question and running a test commit.

Validation steps

  1. Pull down the branch.
  2. Install project dependencies using yarn.
  3. Make a small change to a *.css file.
  4. Commit the file to verify the lint-staged hook runs successfully.
  5. Reset your branch. Do not push the change.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jul 15, 2025

⚠️ No Changeset found

Latest commit: eaef496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf cdransf self-assigned this Jul 15, 2025
@cdransf cdransf added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Jul 15, 2025
Copy link
Contributor

File metrics

Summary

Total size: 2.25 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

🚀 Deployed on https://pr-4039--spectrum-css.netlify.app

@cdransf cdransf merged commit 946ccea into main Jul 15, 2025
17 of 24 checks passed
@cdransf cdransf deleted the cdransf/lint-staged-prettier-fix-main branch July 15, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants