-
Notifications
You must be signed in to change notification settings - Fork 233
fix(picker): add picker attribute to nested popover and styles to constrain to picker width #5767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 18197764400Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love your thoughts on my suggestion!
Changes look good to me, however I'm wondering if this is expected / desired? |
2e6f81a
to
9b2f918
Compare
9b2f918
to
d974ed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds styles to the
popover.css
to enforce a fixed width when the popover is used within the picker component. This aligns with the design documentation and the picker component styles.Motivation and context
Without this change the rendered picker options will grow in width without wrapping for longer labeld.
Related issue(s)
Author's checklist
Manual review test cases
Device review