Skip to content

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Sep 29, 2025

Description

This PR adds styles to the popover.css to enforce a fixed width when the popover is used within the picker component. This aligns with the design documentation and the picker component styles.

Motivation and context

Without this change the rendered picker options will grow in width without wrapping for longer labeld.

Related issue(s)

  • fixes SWC-562

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Manual review test cases

  1. Navigate to the picker docs
  2. Open the picker
  3. Edit one of the options in the inspector, changing the label text to something much longer than the default.
  4. See that the label wraps rather than causing the dropdown to grow horizontally.

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@cdransf cdransf self-assigned this Sep 29, 2025
@cdransf cdransf added the WIP label Sep 29, 2025
Copy link

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: ce748c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 29, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5767

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Sep 29, 2025

Pull Request Test Coverage Report for Build 18197764400

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.919%

Totals Coverage Status
Change from base Build 18196292250: 0.003%
Covered Lines: 34050
Relevant Lines: 34574

💛 - Coveralls

@cdransf cdransf marked this pull request as ready for review September 30, 2025 17:10
@cdransf cdransf requested a review from a team as a code owner September 30, 2025 17:10
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love your thoughts on my suggestion!

@cdransf cdransf requested a review from castastrophe October 1, 2025 15:54
@rubencarvalho
Copy link
Contributor

Changes look good to me, however I'm wondering if this is expected / desired?

@cdransf cdransf requested a review from rubencarvalho October 1, 2025 22:16
@cdransf cdransf force-pushed the cdransf/picker-text-overflow-fix branch 2 times, most recently from 2e6f81a to 9b2f918 Compare October 1, 2025 23:08
@cdransf cdransf requested a review from rubencarvalho October 2, 2025 14:44
@cdransf cdransf force-pushed the cdransf/picker-text-overflow-fix branch from 9b2f918 to d974ed1 Compare October 2, 2025 14:46
@cdransf cdransf enabled auto-merge (squash) October 2, 2025 15:49
Copy link
Contributor

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cdransf cdransf merged commit a253670 into main Oct 2, 2025
29 checks passed
@cdransf cdransf deleted the cdransf/picker-text-overflow-fix branch October 2, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants