Skip to content

Conversation

graynorton
Copy link
Collaborator

Description

This PR updates the Badge and Progress Circle components in the second-gen codebase to align with the barebones architectural patterns. The changes include:

  • Restructuring component implementations to follow barebones patterns
  • Adding TypeScript type definitions in separate .types.ts files
  • Integrating Storybook helpers for improved story generation
  • Re-enabling Custom Elements Manifest (CEM) build
  • Making valid sizes accessible as static properties by updating sizedMixin

These updates improve consistency across the codebase and establish patterns for future component migrations.

Motivation and context

As part of the second-gen component architecture refactor, we're standardizing component structure and patterns. Badge and Progress Circle are being updated to match the established barebones patterns, which improve maintainability, type safety, and documentation generation.

Related issue(s)

  • Contributes to (but does not complete) SWC-1057

Screenshots (if appropriate)

N/A - This is a structural refactor with no visual changes to component appearance.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Badge component renders correctly with all size variants

    1. Navigate to Badge Storybook stories
    2. Verify all size variants render correctly
    3. Verify static validSizes property is accessible
  • Progress Circle component renders correctly with updated patterns

    1. Navigate to Progress Circle Storybook stories
    2. Verify all variants render correctly
    3. Verify component behavior matches previous implementation

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@graynorton graynorton requested a review from a team as a code owner October 6, 2025 18:19
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: a6e376d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 6, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5787

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho merged commit cd77556 into barebones Oct 7, 2025
15 of 22 checks passed
@rubencarvalho rubencarvalho deleted the gnorton/clean-up-barebones-badge-and-progress-circle branch October 7, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants