TNT-38925 - send_notifications implementation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcottingham
force-pushed
the
TNT-38925
branch
from
b1c8796 to
5e91479
Compare
5amfung
approved these changes
Feb 9, 2021
| pip install --upgrade pip "setuptools>=38.3.0,<=44.1.x" wheel pep517 pylint twine bump2version coverage coveralls | ||
| pip install -r requirements.txt | ||
| pip install -r test-requirements.txt | ||
| ifneq (,$(filter $(PYTHON_VERSION),2.7 3.4 3.5)) |
There was a problem hiding this comment.
The github workflow image doesn't already include a proper pip?
There was a problem hiding this comment.
It includes the latest version, which doesn't work for older python builds
target_python_sdk/tests/helpers.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| # Copyright 2020 Adobe. All rights reserved. | |||
| "id": "SummerShoesOfferNotification" | ||
| } | ||
| ] | ||
| } |
jasonwaters
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Looks good @dcottingham ! Apologies for the delay in review.
ericfichtel
pushed a commit
that referenced
this pull request
Sep 22, 2022
ca3c289 TNT-44008 Fix AP pre-fetch documentation (#15) 0df2586 TNT-43882: [Delivery API] Update public docs with ref to click-track metric (#13) 1b0e12d added client hints to context (#14) 8b34ffd Merge pull request #12 from ndiaconu/patch-1 495416c Update AnalyticsRequest.yaml ad59cdd rename telemetry blob field to telemetryServerToken for request and response (#11) 6e6c5af add encoded telemetry fields to support data collected on Edge (#10) be8f79c update TelemetryRequest fields to be double type (#9) 6240685 various bug fixes because java generator strictly follows openapi 3.0 spec (#8) 4bc2f19 TNT-41043 Add more fields to openapi telemetry spec (#7) e4fa8ea Merge pull request #6 from adobe/TNT-40664_2 e2dd234 fix for DeliveryResponse notifications 9cf4475 Add analytics payload to Metric model for A4T support with prefetch (#5) 671d16a Update README.md 28c9893 Merge pull request #4 from adobe/TNT-40664 d25e9e8 Add LF 4bdffa7 Add notifications field to DeliveryResponse bbbf35b TNT-40603 - adding preview mode to Delivery API (#3) 29df471 Add links to README (#1) git-subtree-dir: openapi git-subtree-split: ca3c2892d21f07a1163f7e24df49593fbb1cdfb3
ericfichtel
added a commit
that referenced
this pull request
Nov 3, 2022
* Squashed 'openapi/' changes from ed1850b..ca3c289 ca3c289 TNT-44008 Fix AP pre-fetch documentation (#15) 0df2586 TNT-43882: [Delivery API] Update public docs with ref to click-track metric (#13) 1b0e12d added client hints to context (#14) 8b34ffd Merge pull request #12 from ndiaconu/patch-1 495416c Update AnalyticsRequest.yaml ad59cdd rename telemetry blob field to telemetryServerToken for request and response (#11) 6e6c5af add encoded telemetry fields to support data collected on Edge (#10) be8f79c update TelemetryRequest fields to be double type (#9) 6240685 various bug fixes because java generator strictly follows openapi 3.0 spec (#8) 4bc2f19 TNT-41043 Add more fields to openapi telemetry spec (#7) e4fa8ea Merge pull request #6 from adobe/TNT-40664_2 e2dd234 fix for DeliveryResponse notifications 9cf4475 Add analytics payload to Metric model for A4T support with prefetch (#5) 671d16a Update README.md 28c9893 Merge pull request #4 from adobe/TNT-40664 d25e9e8 Add LF 4bdffa7 Add notifications field to DeliveryResponse bbbf35b TNT-40603 - adding preview mode to Delivery API (#3) 29df471 Add links to README (#1) git-subtree-dir: openapi git-subtree-split: ca3c2892d21f07a1163f7e24df49593fbb1cdfb3 * TNT TNT-45620 initial fix for supporting mbox parameters with dot notation * changing f string to format to support python2 * addressing pslint issues * adding C0209to pylint ignore, adding constructor comment and adding tests to pylint ignore * fixing pylint R1728 error * need to ignore R1728 to pass pylint and support python2 * adding check for unicode type for mbox custom params * consolidating type check * adding W1406 to pylint ignore for python2 support * moving with_lowercase_string_values to contedt_provider * removing unused import * removing extra copy call and changing to is_string * deleting old test schema * Squashed 'target_decisioning_engine/tests/schema/' content from commit 1b1ef83 git-subtree-dir: target_decisioning_engine/tests/schema git-subtree-split: 1b1ef83c0a64a6180eba053b6181399e6a35eacb * code fix to pass dot param and domain parsing integration test * code fix for domain parsing, user agent browser parsing and country code issues * adding python support for url parse * updating readme * cleaning up parse_url and editing readme Co-authored-by: Eric Fichtel <efichtel@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.