Skip to content

refactor: update ready message #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024
Merged

refactor: update ready message #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7cb5af
refactor: update ready message
Julien-R44 May 2, 2024
b5fbf2e
chore: update message
Julien-R44 May 7, 2024
d11a882
chore: use another node arg
Julien-R44 May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/dev_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,9 @@ export class DevServer {
.useColors(this.#colors)
.useRenderer(this.#logger.getRenderer())
.add(`Server address: ${this.#colors.cyan(`http://${host}:${message.port}`)}`)
.add(
`File system watcher: ${this.#colors.cyan(
`${this.#isWatching ? 'enabled' : 'disabled'}`
)}`
)

const watchMode = this.#options.hmr ? 'HMR' : this.#isWatching ? 'Legacy' : 'None'
displayMessage.add(`Watch Mode: ${this.#colors.cyan(watchMode)}`)

if (message.duration) {
displayMessage.add(`Ready in: ${this.#colors.cyan(prettyHrtime(message.duration))}`)
Expand Down
4 changes: 2 additions & 2 deletions tests/run.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ test.group('Child process', () => {
const childProcess = runNode(fs.basePath, {
script: 'foo.ts',
scriptArgs: ['--watch', '--foo=bar'],
nodeArgs: ['--throw-deprecation'],
nodeArgs: ['--conditions=dev'],
})

const payload = await pEvent(childProcess, 'message', { rejectionEvents: ['error'] })
Expand All @@ -74,7 +74,7 @@ test.group('Child process', () => {
process.allowedNodeEnvironmentFlags.has('--disable-warning')
? '--disable-warning=ExperimentalWarning'
: '--no-warnings',
'--throw-deprecation',
'--conditions=dev',
],
})
})
Expand Down