Skip to content

Conversation

marcuspoehls
Copy link
Contributor

❓ Type of change

  • πŸ“ Wording refinement
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Minor wording refinement for the log message when copying the ace.js file.

@RomainLanz
Copy link
Member

Hey @marcuspoehls! πŸ‘‹πŸ»

We donΒ΄t copy the file, we entirely rewrite it. That's why there's a warning inside, advising against adding any extra content.

@marcuspoehls
Copy link
Contributor Author

@RomainLanz Hey Romain, you’re right. My bad. I’ve updated my merge request to change the log message from rewrited … to created …. Maybe you’re open to this log message refinement πŸ™‚

@thetutlage
Copy link
Member

@RomainLanz I think we can go with created keyword. Because, we never rewrite the same ace file. Instead we creating a fresh one inside the build folder. What do you think?

Copy link
Member

@RomainLanz RomainLanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcuspoehls
Copy link
Contributor Author

Cool πŸ™‚

@thetutlage thetutlage merged commit decb806 into adonisjs:7.x Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants