OBG-51: Fix admin delete api #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clovisgakam Please add test based on some test case i.e. WiremockConsentE2EXs2aProtocolTest as a separate test class |
clovisgakam
force-pushed
the
OBG-51_Fix_admin_delete_api
branch
3 times, most recently
from
a51727a
to
8bde88b
Compare
clovisgakam
force-pushed
the
OBG-51_Fix_admin_delete_api
branch
from
8bde88b
to
f005d49
Compare
valb3r
approved these changes
Sep 13, 2021
valb3r
added a commit
that referenced
this pull request
Oct 11, 2021
* Fixed plugin version * Bump version * Start next iteration 0.31.0-SNAPSHOT update version in docker-compose fix git hooks errors * Bump firefly-exporter version * Bump fasterxml.version from 2.10.1 to 2.12.1 Bumps `fasterxml.version` from 2.10.1 to 2.12.1. Updates `jackson-annotations` from 2.10.1 to 2.12.1 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-databind` from 2.10.1 to 2.12.1 - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Updates `jackson-datatype-jsr310` from 2.10.1 to 2.12.1 Signed-off-by: dependabot[bot] <support@github.com> * update to new postgres container * Forced cleanup * OBG-1184. Fixed expired QWAC cert * #1002 xs2a adapter updated to version 0.1.2 * #1002 fix tests * OBG-1002 xs2a adapter version 0.1.4 * test fixes for new xs2a adapter * OBG-1002 xs2a adapter 0.1.8 * OBG-959 update multibanking to 5.5.24 update lombok and mapstruct to work correctly with last intelliJ projectlombok/lombok#2592 * Report free space * Report free space * Allow heavy tests to be started manually * Allow heavy tests to be started manually * Allow heavy tests to be started manually * Allow heavy tests to be started manually * OBG-959 hbci payment status magic numbers meaning changed * OBG-1177. AIS-embedded postman scripts * # Conflicts: # pom.xml * OBG-1002. Updating sandbox * OBG-1002. Updating sandbox * OBG-1002. Sandbox tests fixes * OBG-1002. Make checkstyle happy * OBG-1002. Make PMD happy * OBG-1002. Fixed random test failure * Bump guava from 28.1-jre to 29.0-jre Bumps [guava](https://github.com/google/guava) from 28.1-jre to 29.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Signed-off-by: dependabot[bot] <support@github.com> * OBG-1174. Keep default HBCI urls * Fixed compilation issue * Remove unused imports * Bump guava * Hack for #1199 * Hack for #1199 * Hack for #1199 * Initial modularized analytics * Added result post-processor * Added dummy-mapper * Refactored post-processor application * Fixed POM's * Integrate smart analytics via annotation * Use smartanalytics snapshot * Added dummy mapper * Propagate analytics through API * Propagate analytics through API * Propagate analytics through API * Fixed spring-security leaking from smartanalytics and mapping issues * Propagate analytics result to API * Initial rule resources * Remove remote-resources plugin * Use released smartanalytics * Chain post-processors * Log free space * Bump ubuntu version * Attempt to cleanup overlay2 * Pin postgres version * Added hack for Sandbox message handling * Fix FireFly exporter build * photo otp * Switch to CodeCov action * Fixed tests * Update DEV CodeCov pattern * Fixed test * Initial consent error handling * Initial consent error handling * Improved mapping handling * Implemented consent DELETE Api * Update UI API and add 'Delete in Fintech' button * Make checkstyle happy * OBG-1209 extract sca auth mappings to application properties, test * OBG-1209 fix test * OBG-1209. Small fix * Fixed tests * Add logging to all classes that implement JavaDelegate * fixes in mappers, pmd fixes, deleted unused imports * Bump adapter and cleanup DB blocker * Bump adapter and cleanup DB blocker * Bump adapter and cleanup DB blocker * Added logging * Update adapter bean dependencies * fixes in mappers, xs2a and hbci logresolvers reactoring, added logging of responses and requests * Add custom INTEG deployer * Fixed HBCI logging * Use statuc mapper * Log response for AIS * Allow creating custom consent * Fix mapper and add test * Remove unused imports * Fix UI tests * Fix UI tests * update banks.csv * Fixed missing mapping of grant type in Xs2a adapter * Added Java time module * Use new X-Request-ID * Bugfix/redirect before start (#1233) * Fixed redirects before consent auth start * Set approach from init call * Use special redirection handler * Use special redirection handler * Fixes for payment redirection * Fixed typo * Refactored consent handling * Refactored consent handling * Remove object mapper * Remove object mapper * Remove unnecessary classes * Fixed wrong transaction listing bean * Separate support for skipping start consent authorization * Disable test profiles * add our account iban to hbci transaction mapper (#1230) * Logging in FacadeService and ResultHandler (#1229) * added logging to FacadeService and ResultHandler fixes in XS2A-protocol, HBCI-protocol logging * refactoring, work with comments * refactoring: Constants moved to opba-facade-protocol-api-shared * Fixed FireFly exporter * Resilent smartanalytincs analysis * fixed transaction amount sing for both old and new transactions (#1238) * Bugfix/handle oauth consent (#1256) * Implemented ING quirk * Make checkstyle happy * Revert ConsentOAuth handler * Check bodyLinks for null * Remove unused method * Deepen ING handling * Updated URL mapping * Handle NULL consent id too * Handle NULL consent id too * Handle NULL consent id too * Handle NULL consent id too * Handle consent acquired when consent id is null * Added comment * Fixed mapper * Fixed null consent ID * Simplify dummy consent id handling * [tests] Update wiremock expected URLs to match new pattern * [tests] Fixed another part of issues with redirect code * [tests] Fixed another part of issues with redirect code * [tests] Fixed another part of issues with redirect code * Add possibility to configure consent parameters in ConsentUI (#1236) * Add possibility to configure consent parameters in ConsentUI * fixed date checking in ConsentUI * fixed layout,validation, added form control * fixes according to comments * Normalize paths for windows (#1219) * Normalize paths for windows * Fixes for path normalization on Linux * Fixes for path normalization on Linux * Fixed path mapping * Fixed file separator issue * Feature/simple protocol tester (#1259) * Implemented ING quirk * Make checkstyle happy * Revert ConsentOAuth handler * Check bodyLinks for null * Remove unused method * Deepen ING handling * Updated URL mapping * Handle NULL consent id too * Handle NULL consent id too * Handle NULL consent id too * Handle NULL consent id too * Handle consent acquired when consent id is null * Added comment * Fixed mapper * Fixed null consent ID * Simplify dummy consent id handling * [tests] Update wiremock expected URLs to match new pattern * [tests] Fixed another part of issues with redirect code * [tests] Fixed another part of issues with redirect code * [tests] Fixed another part of issues with redirect code * Added initial layout for testing-helper * Changed package * Renamed helper application * Protocol testing helper application basis implemented * Initialize protocol testing controller * Implemented list accounts handling * Added authorization controller * Renamed authContext getter and fixed search issues * Fixed mappings and added postman collection for Xs2a Sandbox * Make checkstyle happy * Feature/anonymous consent (#1261) * Initial implementation for anonymous consent * Initiated API changes * Fixed tests in FinTech and minor fixes in anonymous consent tests * Fixed configs * Fixed anonymous consent loading * Allow selecting anonymous consent in UI * Unmapped values and checkstyle fixes * Updated API and login controller fixes * Fixed URL path in test * Fixed UI tests * Update PR build script to include FireFly, fix FireFly missing args * Update PR build script to include FireFly, fix FireFly missing args * Pagination for transactions (#1262) * Pagination for transactions * deleted unnecessary code * refactoring * fixes according to comments * Feature/enable extensions (#1264) * Publishing some part of extension binding to OpenSource * Publishing some part of extension binding to OpenSource * More precise protocol loading * Added note about disabling devtools * Added comment * Enabled immediate consent in FinTech * Adding OnLogin action and switching PsuAuth API to async to handle OnLogin action * Adding onLogin call forwarding * Propagate OnLogin action support to upper layers * Finalize OnLogin handler implementation * Added fromAspsp return template * Update mappings for FinAPI * Added comment on config * Renamed pageSize parameter * Extension in separate context * Extension in separate context * Explicit none context * Fixed test * Remove unpublished dependency * Exit on fail * Fixed issue with Fintech server deploy * Postman and other fixes (#1266) * Bugfix/set of minor fixes (#1267) * Postman and other fixes * Increase query range * Feature/delete consent (#1268) * Some initial work for Xs2a * Implemented consent removal for Xs2a * Resolve issues with mappings * Propagate DELETE consent to REST * Added stubs for easier migrations in future * Remove unused import * Fixed mappings, removed stub banks * Added converter for stubs * Remove unused import * Fixed tests * Added postman collections * Rollback stub rows * Fixed mappings and other stuff * Added lost bindings * Fixed mock data handler * Feature/bank search ext (#1269) * Added externalId column * Refactored migrations to use pre-defined contexts * Fixed migrations * Mark sandbox banks explicitly * Added external interfaces declaration * Fixed test * Fixed test * Fixed wrong context * Fixed wrong migration path * Fixed wrong migration path * Fixed tests, use larger column * Added necessary fields * Added missing overrides * Update migration * Update migration * Remove wrong profile * Fixed issues with externalized migrations of liquibase * Fixed issues with externalized migrations of liquibase * Moving smartanalytics to extensions (#1271) * Moving smartanalytics to extensions * Moving smartanalytics to extensions * Change method visibility * Fixed UI test * Add onInit * Fixed UI test * Forcefully set form in test as valid * Disable problematic UI test * Increase webdriver timeout * OBG API clean up (#1270) * OBG API clean up * fixed wiremock tests resources according to cleaned OBG API * returned field "remittanceInformationUnstructured", rephrased endpoint * changed header name (from 'Redirect-Code' to X-XREF-TOKEN), query parameter (from redirectCode to xXrefToken) in ConsentAPI * fixes in IntelliJ Http scripts * fix in Wiremock test * fixed mock date in ConsentUI test * Resolve issue with mocked fixture * Update Postman collections, add smartanalytics enabler * Update Postman collections * Add smartanalytics migration pack * Initialize admin API versioning * Fix for admin tests * Fix issue with JAR based keystore * Сlean up of PIS API (#1279) * clean up of pis api * updated getPaymentStatus test * OBG-1234 Allow fintech pass consent (#1263) * OBG-1234 Allow fintech pass consent * OBG-1234 X-Create-Consent-If-None header as String instead of Object * OBG-1234 add example in api, consent hardcoded in consent-ui * OBG-1234 fixed hardcoded consent object * OBG-1234 fix mapper, add tests * OBG-1234 fix ui-tests * OBG-1234 make consent optional in fintech-ui * OBG-1234 fix consent-ui behavior when fintech doesn't sends consnet header * OBG-1234 add custom consent field in fintech-ui * OBG-1234 add e2e test with consent from fintech * Fixed issue with empty object assertion * Fixed wrong variable mapping * Change defaults to correct values * Feature/date filter on cache (#1281) * Adding date filtering - initial refactor * Generify cache access * Generify cache access * Fix some point locations * Added test for HBCI * Basic Xs2a refactored caching * Share public key too * Added test for authenticated user * Small fixes * Wrong result type fixed * Fixes in test * Fixed checskstyle issues * Updated test fixtures * Fixed anonymous test * Fixed HBCI test and HBCI sandbox booking date * Drop package-lock.json * Add query parameter to delete consent request (#1282) * Fixed smoke test * Feature/bank to bank profile (#1283) * Initialize bank-to-profile mapping * Fixed mappings * Resolve FinTech issues * Updated tests * Updated API definition + migrations * Updated API definition + migrations * Make checkstyle happy * Fixed tests * Fixed update tests * Restructure DB migrations * Restructure DB migrations * Restructure DB migrations * Restructure DB migrations * Further test fixing for restructured DB migrations * Further test fixing for restructured DB migrations * Fixed FinTech tests * Fixed Firefly exporter build * Update FinTech UI * Make checkstyle happy * Update migration and fix tests * Fix UI test * Drop SQL logging * Updated FinTech smoke tests * Fixed smoke tests * Drop unnecessary mapping * Optional profiles * Update Postman tests * Optional profiles * OPEN-3. Import existing user data (#1285) * OPEN-3. Import existing user data * OPEN-3. Added more encryption services * OPEN-3. Added more encryption services * Obg 35: fix DKB Adapter (#1284) * fixed DKB adapter * OBG-35 add Bearer * OBG-35 fix var name * OBG-35 switch to embedded * OBG-35 switch to embedded * OBG-35 switch to embedded * rebase * fix checkstyle errors * OBG-35 set scaAvailableMethods in StartConsentAuthorization * OBG-35 return Embedded * OBG-35 get selected sca type base on user selected sca Id * OBG-35 embedded for dkb adapter liquibase changeset * fixed DKB adapter * OBG-35 add Bearer * OBG-35 fix var name * OBG-35 switch to embedded * OBG-35 switch to embedded * OBG-35 switch to embedded * rebase * fix checkstyle errors * OBG-35 set scaAvailableMethods in StartConsentAuthorization * OBG-35 return Embedded * OBG-35 get selected sca type base on user selected sca Id * OBG-35 embedded for dkb adapter liquibase changeset * cleanup embedded pre step stubs * OBG-35: cleanup and fix reviews comments * OBG-35 handle wrong password for DKB * OBG-35 fix conflicts * OBG-35. Some fixes * OBG-35. Update flows * OBG-35 dkb payment test * OBG-35 dkb payment test * OBG-35 pmd fix * OBG-35 fix changeset context Co-authored-by: Clovis Gakam <cga@ip-192-168-178-35.eu-central-1.compute.internal> Co-authored-by: Maxim Grischenko <grischenko.maxim@gmail.com> Co-authored-by: Clovis Gakam <cga@Cloviss-MBP.fritz.box> Co-authored-by: valb3r <valb3r.ua@gmail.com> * Feature/obg 809 decoupled approach updated (#1286) * OBG 809: Table and entity added * OBG 809: Tests extended * OBG 809: Waiting service added * OBG 809: Bpmn diagrams updated with timers * OBG 809: Unnecessary Db and service changes rollback * OBG 809: Bpmn updated, feign client added * OBG 809: Sca Decoupled is added and set in steps * OBG 809: Decoupled switch added * OBG 809: Payment authorization bpmn updated * OBG 809: Payment authorization bpmn spaces refactored * OBG 809: Unused files removed * OBG 809: Decoupled bpmn switch updated * OBG 809: Ais switch added * OBG 809: Ais subproccess added * OBG 809: Ais subproccess updated, paddings added * OBG 809: Ais/pis bpmn refactoring * OBG 809: Ais/pis bpmn refactoring 2 * OBG 809: Ais bpmn refactoring * OBG 809: Ais/Pis bpmn refactoring 3 * OBG 809: Ais/Pis bpmn beans updated * OBG 809: properties added * OBG 809: Github discussions resolved * OBG 809: Checkstyle fixes * OBG 809: typos removed, tests updated * OBG 809: bpmn typos fixed * OBG 809: stages check method type for decoupled SCA * OBG-809. Fixed diagrams * OBG 809: Fix tests * OBG 809: decoupled stages check fixed, property names updated in bpmn files * OBG 809: durations changed to constant values * OBG 809: added extractor for decoupled stages * OBG 809: property configuration added * OBG 809: NPE fixed, app properties fixed for tests * OBG 809: Consent authorization bpmn target ref corrected * OBG 809: Added redirection to a wating page * OBG 809: Redirection payment bpmn change * OBG 809: Waiting mock pages added ais/pis * OBG 809: One Sca flow fixed not to go as zero SCA * OBG 809: BPMN service key fix * OBG 809: Added SCA status setting * OBG 809: unused properties removed * Some merge updates * OBG-809. Resolved build issues * OBG-809. Re-merged diagrams * OBG-809. Updated timer definition and poll interval * OBG-809. Updated decoupled process recognition * OBG-809. Fixed multi SCA case * OBG-809. Updated status retrieval * OBG-809. Adapt flows for API calls * OBG-809. Rollback key pinning * OBG-809. Dropped unused component and update stuff * Fixed redirectCode mappings * Fixed process layouts * OBG-809. Update auth flows * OBG-809. Update controller and mapping * OBG-809. Update UI and mappings * OBG-809. Update mappers * OBG-809. Fixed checkstyle issue * OBG-809. Fixed test issue * OBG-809. Drop UI tests * OBG-809. Added test stubs and fixes * OBG-809. Added test stubs and fixes * OBG-809. Removed Flowable warnings * OBG-809. Fixed concurrency issue with requests from UI * OBG-809. Fixed concurrency issue with requests from UI * OBG-809. Fixed compilation issue * OBG-809. Fixed tests * OBG-809. Fixed PMD * OBG-809. Fixed payment test part * OBG-809. Fixed payment test part * OBG-809. Decoupled payment tests * OBG-809. Support validation rule for decoupled * OBG-809. PMD and checkstyle happy * OBG-809. Support validation rule for decoupled * OBG-809. Restore url Co-authored-by: iiuex <iiu@adorsys.com.ua> * Remove unnecessary logging * Remove unnecessary logging * OBG-43: Fix Postbank adapter integration and add payments and accounts e2e tests (#1289) * fix postbank adapter integration and add payments and accounts e2e tests * cleanup pom * revert fintech ui changes * cleanup and fix reviews conversations * fix formating issues * fix merged conflicts * OBG-46: Add consorsbank e2e tests (#1291) * add consorsbank e2e tests * fix pmd code duplication * fix merged conflicts * fix merged conflicts * Add query parameter to bankSearch endpoints, (#1290) * Add query parameter to bankSearch endpoints, add isActive field to bank, bankProfile, add migration * Included migration to master * fixed column names * fixed test * fixed fireflyExporter, mappers * fixed query to get desired banks directly from DB fixed var names to fix bug with DB data mapping fixes in api deleted deprecated filter from service * fixed query (selected field name) * add isActive to AdminApi etc. * fixed queries in all ymls * Force using wrapper instead of maven * Force using wrapper instead of maven * Feature/open 11 get consent status (#1292) * Remove unnecessary logging * OPEN-11. Auth session status persistence * OPEN-11. Added basic API definition * OPEN-11. Updated Springdoc UI * OPEN-11. Added status bindings * OPEN-11. Get consent status services * OPEN-11. Fix logging issues and handle status correctly * OPEN-11. Add PIS status handling too * OPEN-11. Merged with develop * OPEN-11. Support 'lastRequestId' * OPEN-11. Fixed test * OPEN-11. Added tests * OPEN-11. Rename method * OBG-51: Fix patch admin banks api (#1293) * fix patch admin bank api * fix review conversations * Obg 34 fix sparkasse list transactions (#1288) * OBG-34 add content type JSON as standart xs2a header * OBG-34 getTransactionListAsString as fallback * OBG-34 content type of transactions in bank profile, xml transactions parser * OBG-34 fix checkstyle, improve mapper * OBG-34 add rawTransactions field in Api * OBG-34 sparkasse list transactions wiremock test * OBG-34 fix sparkasse wiremock test * OBG-34 fix test * OBG-34 after rebase fix * Remove unused configuration property (#1297) * OBG-51: Fix admin delete api (#1295) * OBG-51: Fix admin delete api * OBG-51: add e2e tests for delete bank admin api * OPEN-51. Added PIS delete bank test * OPEN-51. Slight reformatting * OPEN-51. Slight reformatting * OPEN-51. Fix db cleanup Co-authored-by: valb3r <valb3r.ua@gmail.com> * OPEN-11. Add protocol status handler for FinAPI (#1298) * OPEN-11. Add protocol status handler for FinAPI * Fixed migrations * OPEN-11. Handle consent details * Feature/open 11 add consent status details (#1299) * OPEN-11. Handle error results from protocol * OPEN-11. Handle consent details * OPEN-11. Handle consent details * OPEN-100. Added note (#1300) * OPEN-98. Support more FinAPI parameters (#1301) * Add paging support for xs2a-protocol (#1296) * add paging support for xs2a-protocol * fix bug with setting null paging values * fixes according to comments added const, added separate test for paging * OBG-42. add Santander e2e tests (#1302) * OBG-42. add Santander bank Account list e2e test * OBG-42. moved Satander stubs into oauths integrated folder * OBG-42. add santander payment e2e test * Feature/open 99 support for external sync (#1303) * OPEN-99. Support force-connection update method * OPEN-98. Make checkstyle happy * OPEN-99. Added extra enum mapping * OPEN-99. Added migration * OBG-95 Document the usage of PSU-IP-Address and Compute-PSU-IP-Address headers (#1305) * Add headers to api. Fix controllers, tests. * Fix header names, e2e tests with computing ip. * Fix firefly services according to updated OBG API * Feature/open 102 bank consent type (#1306) * OPEN-102. Initialize consent type support * OPEN-102. Use multiple types * OPEN-102. Some cleanup, remove custom consent * OPEN-102. Updated UI accordingly * OPEN-102. Updated UI accordingly - use auto-selected * OPEN-102. Fixed migration * OPEN-102. Fixed UI test * OPEN-102. Fixed UI test * Skip start auth consors bank (#1304) * skip start authorisation for consors bank * remove unneeded stubs * OPEN-102. Fixed consent UI branch * Feature/open 30 add external ids (#1309) * OPEN-30. Added external IDs to API * OPEN-30. Added external IDs entities * OBG-41. fix Targo Bank Adapter Integration and Add AIS e2e test. (#1308) * update ci * OBG-41. fix Targo Bank Adapter Integration and Add Ais e2e test. * O1. fix failing tests * OB add targo bank Pis e2e test * OBG-41. cleanup * OBG-41. fix reviews comments * cleanup * Add config values * Add config values * Feature/update documentation (#1310) * Add notice about License change * Add notice about License change * Added links + big picture * OBG-50. add sandbox ais and pis e2e test embedded with one sca (#1312) * OBG-36 OBGBankSearch API returns null (#1311) * Add blank keyword check to bankSearchGET() in TppBankSearchController * Fixes according to comments, fixes in agruments order * Fixed date mapping in transactions from camt (#1313) * OBG-38_volksbank_test (#1307) * OBG-38_volksbank_test * OBG-38 authorization with pin for fiducia * OBG-38 required/new scenario state in stubs * OBG-38 add test getTransactions * OBG-38 migration sequence numbers fix, formatting fix * method name fixes * Bump version to release Co-authored-by: Maxim Grischenko <grischenko.maxim@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: peter <peter@admins-MBP-2.fritz.box> Co-authored-by: tsehelnyk <58398447+tsehelnyk@users.noreply.github.com> Co-authored-by: Maxim Grischenko <mhr@adorsys.de> Co-authored-by: Clovis Gakam <clovis.gakam@gmail.com> Co-authored-by: Clovis Gakam <cga@ip-192-168-178-35.eu-central-1.compute.internal> Co-authored-by: Clovis Gakam <cga@Cloviss-MBP.fritz.box> Co-authored-by: iiuex <iiu@adorsys.com.ua> Co-authored-by: Clovis Gakam <cga@adorsys.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.