Fix shared flow step LogArgumentToListener #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
over sharing of flow steps was occuring unintentionally
previously lost some intentional sharing
...script/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow/FlowSteps.qll
Outdated
Show resolved
Hide resolved
...script/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow/FlowSteps.qll
Show resolved
Hide resolved
jeongsoolee09
requested changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
over sharing of flow steps was occuring unintentionally
What This PR Contributes
previously in release 2.1.0 the definition of the additional flow step of the UI5LogsToHttp.ql query had an inlined implementation of logger access , this was then refactored and added into a shared step that had a union result that meant the query unintentionally no longer constrained on going through logging functionality only (which is a requirement of the query)
Future Works
potentially consider a different, more correct mechanism to allow for sharing of this flow step (if that makes sense) across different situations