Skip to content

Fix shared flow step LogArgumentToListener #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2025
Merged

Fix shared flow step LogArgumentToListener #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
768e57f
Fix shared flow step LogArgumentToListener
knewbury01 Oct 2, 2025
fb52bfe
Refactor fix logger step
knewbury01 Oct 2, 2025
0c4e3b1
Address review comments
knewbury01 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ipt/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5LogsToHttpQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,9 @@ module UI5LogEntryToHttp implements DataFlow::StateConfigSig {
UI5LogInjection::isAdditionalFlowStep(start, end) and
preState = postState
or
exists(LogArgumentToListener logArgumentToListener |
logArgumentToListener.step(start, end) and
preState = "not-logged-not-accessed" and
postState = "logged-and-accessed"
)
logArgumentToListener(start, end) and
preState = "not-logged-not-accessed" and
postState = "logged-and-accessed"
}

predicate isSink(DataFlow::Node node, FlowState state) {
Expand Down
22 changes: 15 additions & 7 deletions ...ipt/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow/FlowSteps.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,18 +343,26 @@ class ResourceBundleGetTextCallArgToReturnValueStep extends DataFlow::SharedFlow
}
}

/**
* A step from any argument of a SAP logging function to the `onLogEntry`
* method of a custom log listener in the same application.
*/
predicate logArgumentToListener(DataFlow::Node start, DataFlow::Node end) {
inSameWebApp(start.getFile(), end.getFile()) and
start =
ModelOutput::getATypeNode("SapLogger")
.getMember(["debug", "error", "fatal", "info", "trace", "warning"])
.getACall()
.getAnArgument() and
end = ModelOutput::getATypeNode("SapLogEntries").asSource()
}

/**
* A step from any argument of a SAP logging function to the `onLogEntry`
* method of a custom log listener in the same application.
*/
class LogArgumentToListener extends DataFlow::SharedFlowStep {
override predicate step(DataFlow::Node start, DataFlow::Node end) {
inSameWebApp(start.getFile(), end.getFile()) and
start =
ModelOutput::getATypeNode("SapLogger")
.getMember(["debug", "error", "fatal", "info", "trace", "warning"])
.getACall()
.getAnArgument() and
end = ModelOutput::getATypeNode("SapLogEntries").asSource()
logArgumentToListener(start, end)
}
}